Skip to content

feat: add C ndarray API and refactor blas/ext/base/sdsapxsumpw #4815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 23, 2025
Merged

feat: add C ndarray API and refactor blas/ext/base/sdsapxsumpw #4815

merged 7 commits into from
Jan 23, 2025

Conversation

@headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • add C ndarray API and refactor blas/ext/base/sdsapxsumpw

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@headlessNode
feat: add C ndarray API and refactor
dad16eb 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@headlessNode headlessNode added the Feature Issue or pull request for adding a new feature. label Jan 19, 2025
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). and removed Feature Issue or pull request for adding a new feature. labels Jan 19, 2025
@headlessNode headlessNode added C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. labels Jan 19, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 19, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/sdsapxsumpw $\color{green}439/439$
$\color{green}+100.00\%$ 		$\color{green}24/24$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}439/439$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@headlessNode
Copy link
Member Author

@kgryte In the C implementation here, do we return a double so we won't cast it in the addon.c or do we return float and cast to double in the addon.c. The documentation seems a little unclear to me in that respect.

kgryte
kgryte reviewed Jan 19, 2025
View reviewed changes
kgryte
kgryte reviewed Jan 19, 2025
View reviewed changes
@kgryte
Copy link
Member

kgryte commented Jan 19, 2025

we return float and cast to double in the addon.c.

Yes. What you have currently is correct. The function name conveys the type signature. Namely, sds means

  • s: return a single-precision result
  • d: accumulate in double-precision
  • s: accept a single-precision array

headlessNode
headlessNode commented Jan 20, 2025
View reviewed changes
@headlessNode
fix: apply review suggestions
1ff955a 
Signed-off-by: Muhammad Haris <[email protected]>
@headlessNode
docs: apply review suggestion
43992bb 
Signed-off-by: Muhammad Haris <[email protected]>
@headlessNode
Copy link
Member Author

Test failure from a downstream package.

@headlessNode headlessNode marked this pull request as ready for review January 20, 2025 07:47
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 20, 2025
headlessNode
headlessNode commented Jan 20, 2025
View reviewed changes
@headlessNode
docs: fix trailing whitespace
4a43628 
Signed-off-by: Muhammad Haris <[email protected]>
headlessNode
headlessNode commented Jan 20, 2025
View reviewed changes
headlessNode
headlessNode commented Jan 20, 2025
View reviewed changes
kgryte
kgryte approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
Copy link
Member

kgryte commented Jan 23, 2025

As the test failure is expected, I'll go ahead and merge.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jan 23, 2025
@kgryte kgryte merged commit edcbd07 into stdlib-js:develop Jan 23, 2025
12 of 13 checks passed
@headlessNode headlessNode deleted the refactor-sdsapxsumpw branch January 23, 2025 04:50
Vinit-Pandit pushed a commit to Vinit-Pandit/stdlibMine that referenced this pull request Feb 4, 2025
@headlessNode @kgryte @Vinit-Pandit
feat: add C ndarray API and refactor blas/ext/base/sdsapxsumpw
aa249f1 
PR-URL: stdlib-js#4815
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@headlessNode @kgryte @ShabiShett07
feat: add C ndarray API and refactor blas/ext/base/sdsapxsumpw
4eb0e81 
PR-URL: stdlib-js#4815
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@headlessNode @stdlib-bot @kgryte